Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MFG creation on sampling gpus for cugraph dgl #3742

Merged
merged 69 commits into from
Jul 28, 2023
Merged

Support MFG creation on sampling gpus for cugraph dgl #3742

merged 69 commits into from
Jul 28, 2023

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Jul 25, 2023 •
edited
Loading

This PR builds on top of #3734

Merge after #3734

Todo tests for:

  • _get_renumber_map
  • _get_tensor_d_from_sampled_df
  • create_homogeneous_sampled_graphs_from_dataframe
  • pytests pass
  • dataset_from_disk_cudf.ipynb (obgn_products_sampling/)
  • Verify training benchmark

seunghwak and others added 30 commits July 13, 2023 14:08
@seunghwak
define sampling output renumbering function API
6263b9f
@seunghwak
update the API (remove multi_gpu flag)
6c88e86
@seunghwak
initial draft implementation
055496f
@seunghwak
Merge branch 'branch-23.08' of github.com:rapidsai/cugraph into fea_mfg
27fe4f0
@seunghwak
add test code
2211d24
@seunghwak
bug fixes
9fe5e13
@seunghwak
minor tweaks
9ad3c8f
@ChuckHastings
define API for MFG renumbering in the C API
dfbc196
@ChuckHastings
define API for MFG renumbering in the C API
bc5d3e1
@seunghwak
memory footprint cut
012d392
@seunghwak
code improvemnt
63759b8
@seunghwak
bug fix and memory footprint optimization
e21bcd0
@seunghwak
bug fix
7010081
@seunghwak
clang-format
d4d5407
@seunghwak
Merge branch 'branch-23.08' of github.com:rapidsai/cugraph into fea_mfg
a746701
@seunghwak
clang-format
cf7dff8
@seunghwak
remove unnecessary template parameter
948ad11
@seunghwak
clang-format
b26523b
@alexbarghi-nv
Merge branch 'mfg_capi' of https://github.com/chuckhastings/cugraph i…
141bab9 
…nto cugraph-sample-side-mfg
@alexbarghi-nv
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
ff813dd 
…ugraph-sample-side-mfg
@alexbarghi-nv
Merge branch 'branch-23.08' into mfg_capi
37c08e8
@seunghwak
copyright year
f0e5779
@ChuckHastings
Merge remote-tracking branch 'seunghwa/fea_mfg' into mfg_capi
8222c18
@seunghwak
move expand_sparse_offsets from src/detail to include/cugraph/utiliti…
9a8abee 
…es/misc_utils.cuh
@seunghwak
update renumber_sampled_edgelist to use the existing expand_sparse_of…
d4d4c78 
…fsets
@seunghwak
Merge branch 'branch-23.08' of github.com:rapidsai/cugraph into fea_mfg
c6d1d10
@ChuckHastings
Merge branch 'mfg_capi' of github.com:chuckhastings/cugraph into mfg_…
51a05bf 
…capi
@ChuckHastings
Testing with Seunghwa's branch merged in
1e4174e
@alexbarghi-nv
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
b1dac25 
…ugraph-sample-side-mfg
@alexbarghi-nv
c
fa734fb
@VibhuJawa VibhuJawa added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 25, 2023
@VibhuJawa VibhuJawa added this to the 23.08 milestone Jul 25, 2023
@VibhuJawa VibhuJawa marked this pull request as ready for review July 25, 2023 20:27
@VibhuJawa VibhuJawa requested a review from a team as a code owner July 25, 2023 20:27
@VibhuJawa VibhuJawa added the DO NOT MERGE Hold off on merging; see PR for details label Jul 25, 2023
alexbarghi-nv
alexbarghi-nv approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@VibhuJawa VibhuJawa removed the DO NOT MERGE Hold off on merging; see PR for details label Jul 27, 2023
@VibhuJawa
Copy link
Member Author

@alexbarghi-nv / @rlratzel , This is good to go from my end now.

alexbarghi-nv
alexbarghi-nv approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit be2a63e into rapidsai:branch-23.08 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

Assignees

@VibhuJawa VibhuJawa

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.08
Development

Successfully merging this pull request may close these issues.
5 participants
@VibhuJawa @alexbarghi-nv @seunghwak @ChuckHastings @rlratzel